tbianchini
/
shopit-back
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat: remove BankAccount domain and related functionality, including controller, model, requests, routes, and tests

This commit is contained in:
ncoronel 2026-07-06 16:53:45 -03:00
parent 1fcb3129ea
commit 2c2cf45f78
13 changed files with 75 additions and 535 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

76
app/Domains/BankAccount/Controllers/BankAccountController.php
View File

@ -1,76 +0,0 @@
<?php
namespace App\Domains\BankAccount\Controllers;
use App\Domains\BankAccount\Models\BankAccount;
use App\Domains\Tenant\Models\Tenant;
use App\Domains\BankAccount\Requests\StoreBankAccountRequest;
use App\Domains\BankAccount\Requests\UpdateBankAccountRequest;
use App\Domains\BankAccount\Resources\BankAccountResource;
use App\Domains\Tenant\Resources\TenantResource;
use App\Http\Controllers\Controller;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\Response;
class BankAccountController extends Controller
{
public function index(Tenant $tenant): JsonResponse
{
$accounts = $tenant->bankAccounts()->latest()->get();
return BankAccountResource::collection($accounts)->response();
}
public function store(StoreBankAccountRequest $request, Tenant $tenant): JsonResponse
{
$data = $request->validated();
$data['tenant_code'] = $tenant->codigo;
$account = BankAccount::query()->create($data);
return BankAccountResource::make($account)->response()->setStatusCode(201);
}
public function show(Tenant $tenant, BankAccount $bankAccount): BankAccountResource
{
abort_if($bankAccount->tenant_code !== $tenant->codigo, 404);
return BankAccountResource::make($bankAccount);
}
public function update(UpdateBankAccountRequest $request, Tenant $tenant, BankAccount $bankAccount): BankAccountResource
{
abort_if($bankAccount->tenant_code !== $tenant->codigo, 404);
$bankAccount->update($request->validated());
return BankAccountResource::make($bankAccount);
}
public function destroy(Tenant $tenant, BankAccount $bankAccount): Response
{
abort_if($bankAccount->tenant_code !== $tenant->codigo, 404);
$bankAccount->delete();
return response()->noContent();
}
public function select(Tenant $tenant, BankAccount $bankAccount): TenantResource
{
abort_if($bankAccount->tenant_code !== $tenant->codigo, 400, 'La cuenta bancaria no pertenece a este tenant.');
$tenant->selected_bank_account_id = $bankAccount->id;
$tenant->save();
return TenantResource::make($tenant->loadMissing(['headerLogo', 'footerLogo']));
}
public function selected(Tenant $tenant): JsonResponse
{
$account = $tenant->selectedBankAccount;
abort_if(!$account, 404, 'No hay ninguna cuenta bancaria seleccionada para este tenant.');
return BankAccountResource::make($account)->response();
}
}

29
app/Domains/BankAccount/Models/BankAccount.php
View File

@ -1,29 +0,0 @@
<?php
namespace App\Domains\BankAccount\Models;
use App\Domains\Tenant\Models\Tenant;
use Illuminate\Database\Eloquent\Factories\HasFactory;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Relations\BelongsTo;
class BankAccount extends Model
{
use HasFactory;
protected $fillable = [
'tenant_code',
'titular',
'entidad',
'alias',
'cvu',
];
/**
* @return BelongsTo<Tenant, $this>
*/
public function tenant(): BelongsTo
{
return $this->belongsTo(Tenant::class, 'tenant_code', 'codigo');
}
}

47
app/Domains/BankAccount/Requests/StoreBankAccountRequest.php
View File

@ -1,47 +0,0 @@
<?php
namespace App\Domains\BankAccount\Requests;
use Illuminate\Foundation\Http\FormRequest;
class StoreBankAccountRequest extends FormRequest
{
public function authorize(): bool
{
return true;
}
/**
* @return array<string, mixed>
*/
public function rules(): array
{
return [
'titular' => ['required', 'string', 'max:255'],
'entidad' => ['required', 'string', 'max:255'],
'alias' => ['required', 'string', 'max:255'],
'cvu' => ['required', 'string', 'max:255'],
];
}
/**
* @return array<string, string>
*/
public function messages(): array
{
return [
'titular.required' => 'El campo titular es obligatorio.',
'titular.string' => 'El campo titular debe ser una cadena de texto.',
'titular.max' => 'El campo titular no debe superar los 255 caracteres.',
'entidad.required' => 'El campo entidad es obligatorio.',
'entidad.string' => 'El campo entidad debe ser una cadena de texto.',
'entidad.max' => 'El campo entidad no debe superar los 255 caracteres.',
'alias.required' => 'El campo alias es obligatorio.',
'alias.string' => 'El campo alias debe ser una cadena de texto.',
'alias.max' => 'El campo alias no debe superar los 255 caracteres.',
'cvu.required' => 'El campo cvu es obligatorio.',
'cvu.string' => 'El campo cvu debe ser una cadena de texto.',
'cvu.max' => 'El campo cvu no debe superar los 255 caracteres.',
];
}
}

43
app/Domains/BankAccount/Requests/UpdateBankAccountRequest.php
View File

@ -1,43 +0,0 @@
<?php
namespace App\Domains\BankAccount\Requests;
use Illuminate\Foundation\Http\FormRequest;
class UpdateBankAccountRequest extends FormRequest
{
public function authorize(): bool
{
return true;
}
/**
* @return array<string, mixed>
*/
public function rules(): array
{
return [
'titular' => ['sometimes', 'string', 'max:255'],
'entidad' => ['sometimes', 'string', 'max:255'],
'alias' => ['sometimes', 'string', 'max:255'],
'cvu' => ['sometimes', 'string', 'max:255'],
];
}
/**
* @return array<string, string>
*/
public function messages(): array
{
return [
'titular.string' => 'El campo titular debe ser una cadena de texto.',
'titular.max' => 'El campo titular no debe superar los 255 caracteres.',
'entidad.string' => 'El campo entidad debe ser una cadena de texto.',
'entidad.max' => 'El campo entidad no debe superar los 255 caracteres.',
'alias.string' => 'El campo alias debe ser una cadena de texto.',
'alias.max' => 'El campo alias no debe superar los 255 caracteres.',
'cvu.string' => 'El campo cvu debe ser una cadena de texto.',
'cvu.max' => 'El campo cvu no debe superar los 255 caracteres.',
];
}
}

27
app/Domains/BankAccount/Resources/BankAccountResource.php
View File

@ -1,27 +0,0 @@
<?php
namespace App\Domains\BankAccount\Resources;
use Illuminate\Http\Request;
use Illuminate\Http\Resources\Json\JsonResource;
/**
* @mixin \App\Domains\BankAccount\Models\BankAccount
*/
class BankAccountResource extends JsonResource
{
/**
* @return array<string, mixed>
*/
public function toArray(Request $request): array
{
return [
'id' => $this->id,
'tenant_code' => $this->tenant_code,
'titular' => $this->titular,
'entidad' => $this->entidad,
'alias' => $this->alias,
'cvu' => $this->cvu,
];
}
}

13
app/Domains/BankAccount/routes/api.php
View File

@ -1,13 +0,0 @@
<?php
use App\Domains\BankAccount\Controllers\BankAccountController;
use Illuminate\Support\Facades\Route;
Route::prefix('tenants/{tenant:codigo}')->group(function (): void {
Route::middleware('auth:sanctum')->group(function (): void {
Route::get('bank-accounts/selected', [BankAccountController::class, 'selected']);
Route::post('bank-accounts/{bank_account}/select', [BankAccountController::class, 'select']);
Route::apiResource('bank-accounts', BankAccountController::class)
->parameters(['bank-accounts' => 'bank_account']);
});
});

12
app/Domains/Integration/Services/TelepagosIntegrationService.php
View File

@ -167,6 +167,18 @@ class TelepagosIntegrationService extends BaseIntegrationService
]);
}
/**
* Get the account info.
*
* @return array
* @throws Exception
*/
public function getAccountInfo(): array
{
$response = $this->sendRequest('get', '/v2/account/info');
return $this->handleResponse($response, 'get account info');
}
/**
* Handle the Telepagos API response, logging any failures and throwing Exceptions.
*

29
app/Domains/Purchase/Controllers/PurchaseController.php
View File

@ -61,17 +61,26 @@ class PurchaseController extends Controller
]);
if ($method === 'transfer') {
$bankAccount = $tenant->selectedBankAccount;
$telepagosService = new \App\Domains\Integration\Services\TelepagosIntegrationService();
$telepagosService->forTenant($tenant->codigo);
return response()->json([
'payment_method' => 'transfer',
'transfer_data' => $bankAccount ? [
'titular' => $bankAccount->titular,
'entidad' => $bankAccount->entidad,
'alias' => $bankAccount->alias,
'cvu' => $bankAccount->cvu,
] : null,
]);
try {
$accountInfo = $telepagosService->getAccountInfo();
return response()->json([
'payment_method' => 'transfer',
'transfer_data' => [
'titular' => $accountInfo['holder'] ?? null,
'cvu' => $accountInfo['cvu'] ?? null,
'alias' => $accountInfo['alias'] ?? null,
'cuit' => $accountInfo['cuit'] ?? null,
],
]);
} catch (\Exception $e) {
return response()->json([
'message' => 'Error getting account info: ' . $e->getMessage()
], 500);
}
}
if ($method === 'qr') {

20
app/Domains/Tenant/Models/Tenant.php
View File

@ -3,7 +3,6 @@
namespace App\Domains\Tenant\Models;
use App\Domains\Attachable\Models\Attachment;
use App\Domains\BankAccount\Models\BankAccount;
use App\Domains\Catalog\Models\Product;
use Illuminate\Database\Eloquent\Attributes\Fillable;
use Illuminate\Database\Eloquent\Factories\HasFactory;
@ -49,28 +48,9 @@ class Tenant extends Model
return $this->belongsTo(Attachment::class, 'footer_logo_id');
}
/**
* @return HasMany<Product, $this>
*/
public function productos(): HasMany
{
return $this->hasMany(Product::class, 'tenant_codigo', 'codigo');
}
/**
* @return HasMany<BankAccount, $this>
*/
public function bankAccounts(): HasMany
{
return $this->hasMany(BankAccount::class, 'tenant_code', 'codigo');
}
/**
* @return BelongsTo<BankAccount, $this>
*/
public function selectedBankAccount(): BelongsTo
{
return $this->belongsTo(BankAccount::class, 'selected_bank_account_id');
}
}

44
database/migrations/2026_07_06_194803_drop_bank_accounts_table.php Normal file
View File

@ -0,0 +1,44 @@
<?php
use Illuminate\Database\Migrations\Migration;
use Illuminate\Database\Schema\Blueprint;
use Illuminate\Support\Facades\Schema;
return new class extends Migration
{
/**
* Run the migrations.
*/
public function up(): void
{
Schema::table('tenants', function (Blueprint $table) {
$table->dropForeign(['selected_bank_account_id']);
$table->dropColumn('selected_bank_account_id');
});
Schema::dropIfExists('bank_accounts');
}
/**
* Reverse the migrations.
*/
public function down(): void
{
Schema::create('bank_accounts', function (Blueprint $table) {
$table->id();
$table->string('tenant_code');
$table->string('titular');
$table->string('entidad');
$table->string('alias');
$table->string('cvu');
$table->timestamps();
$table->foreign('tenant_code')->references('codigo')->on('tenants')->onDelete('cascade');
});
Schema::table('tenants', function (Blueprint $table) {
$table->unsignedBigInteger('selected_bank_account_id')->nullable();
$table->foreign('selected_bank_account_id')->references('id')->on('bank_accounts')->onDelete('set null');
});
}
};

27
database/seeders/TenantSeeder.php
View File

@ -85,32 +85,5 @@ class TenantSeeder extends Seeder
'header_logo' => $headerLogo,
'footer_logo' => $footerLogo,
]);
$bankAccount1 = \App\Domains\BankAccount\Models\BankAccount::query()->create([
'tenant_code' => $tenant->codigo,
'titular' => 'Sonder S.A. (Principal)',
'entidad' => 'Banco de la Nación Argentina',
'alias' => 'sonder.indumentaria',
'cvu' => '0110065420006540987654',
]);
\App\Domains\BankAccount\Models\BankAccount::query()->create([
'tenant_code' => $tenant->codigo,
'titular' => 'Sonder S.A. (Secundaria)',
'entidad' => 'Banco de Galicia y Buenos Aires',
'alias' => 'sonder.indumentaria.galicia',
'cvu' => '0070012345678901234567',
]);
\App\Domains\BankAccount\Models\BankAccount::query()->create([
'tenant_code' => $tenant->codigo,
'titular' => 'Sonder S.A. (Mercado Pago)',
'entidad' => 'Mercado Pago',
'alias' => 'sonder.indumentaria.mp',
'cvu' => '0000003100012345678901',
]);
$tenant->selected_bank_account_id = $bankAccount1->id;
$tenant->save();
}
}

1
routes/api.php
View File

@ -9,5 +9,4 @@ require __DIR__.'/../app/Domains/Cart/routes/api.php';
require __DIR__.'/../app/Domains/StorageTest/routes/api.php';
require __DIR__.'/../app/Domains/Purchase/routes/api.php';
require __DIR__.'/../app/Domains/Tenant/routes/api.php';
require __DIR__.'/../app/Domains/BankAccount/routes/api.php';
require __DIR__.'/../app/Domains/Integration/routes/api.php';

242
tests/Feature/Tenant/BankAccountControllerTest.php
View File

@ -1,242 +0,0 @@
<?php
namespace Tests\Feature\Tenant;
use App\Domains\BankAccount\Models\BankAccount;
use App\Domains\Tenant\Models\Tenant;
use App\Domains\Auth\Models\User;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Tests\TestCase;
class BankAccountControllerTest extends TestCase
{
use RefreshDatabase;
private Tenant $tenant;
private User $user;
protected function setUp(): void
{
parent::setUp();
$hdrKey = (string) \Illuminate\Support\Str::uuid();
$ftrKey = (string) \Illuminate\Support\Str::uuid();
$headerAttachment = \App\Domains\Attachable\Models\Attachment::create([
'key' => $hdrKey,
'path' => 'tenants/' . $hdrKey . '.png',
'filename' => 'logo_header.png',
'type' => \App\Domains\Attachable\Enums\AttachmentType::Image,
'mime_type' => 'image/png',
]);
$footerAttachment = \App\Domains\Attachable\Models\Attachment::create([
'key' => $ftrKey,
'path' => 'tenants/' . $ftrKey . '.png',
'filename' => 'logo_footer.png',
'type' => \App\Domains\Attachable\Enums\AttachmentType::Image,
'mime_type' => 'image/png',
]);
$this->tenant = Tenant::create([
'codigo' => 'acme',
'nombre' => 'Acme',
'dominio' => 'acme.com',
'primary_color' => '#ff0000',
'secondary_color' => '#00ff00',
'danger_color' => '#0000ff',
'success_color' => '#00ff00',
'header_bg_color' => '#ffffff',
'footer_bg_color' => '#ffffff',
'header_logo_id' => $headerAttachment->id,
'footer_logo_id' => $footerAttachment->id,
]);
$this->user = User::factory()->create();
$this->actingAs($this->user, 'sanctum');
}
public function test_it_lists_bank_accounts_for_a_tenant(): void
{
BankAccount::query()->create([
'tenant_code' => 'acme',
'titular' => 'John Doe',
'entidad' => 'Banco Galicia',
'alias' => 'john.doe.galicia',
'cvu' => '1234567890123456789012',
]);
$response = $this->getJson("/api/tenants/acme/bank-accounts");
$response->assertOk()
->assertJsonCount(1, 'data')
->assertJsonPath('data.0.titular', 'John Doe');
}
public function test_it_creates_a_bank_account_for_a_tenant(): void
{
$response = $this->postJson("/api/tenants/acme/bank-accounts", [
'titular' => 'Jane Doe',
'entidad' => 'Banco Nación',
'alias' => 'jane.doe.nacion',
'cvu' => '9876543210987654321098',
]);
$response->assertCreated()
->assertJsonPath('data.titular', 'Jane Doe');
$this->assertDatabaseHas('bank_accounts', [
'tenant_code' => 'acme',
'titular' => 'Jane Doe',
]);
}
public function test_it_shows_a_bank_account(): void
{
$account = BankAccount::query()->create([
'tenant_code' => 'acme',
'titular' => 'John Doe',
'entidad' => 'Banco Galicia',
'alias' => 'john.doe.galicia',
'cvu' => '1234567890123456789012',
]);
$response = $this->getJson("/api/tenants/acme/bank-accounts/{$account->id}");
$response->assertOk()
->assertJsonPath('data.titular', 'John Doe');
}
public function test_it_updates_a_bank_account(): void
{
$account = BankAccount::query()->create([
'tenant_code' => 'acme',
'titular' => 'John Doe',
'entidad' => 'Banco Galicia',
'alias' => 'john.doe.galicia',
'cvu' => '1234567890123456789012',
]);
$response = $this->putJson("/api/tenants/acme/bank-accounts/{$account->id}", [
'titular' => 'John Doe Updated',
]);
$response->assertOk()
->assertJsonPath('data.titular', 'John Doe Updated');
$this->assertDatabaseHas('bank_accounts', [
'id' => $account->id,
'titular' => 'John Doe Updated',
]);
}
public function test_it_deletes_a_bank_account(): void
{
$account = BankAccount::query()->create([
'tenant_code' => 'acme',
'titular' => 'John Doe',
'entidad' => 'Banco Galicia',
'alias' => 'john.doe.galicia',
'cvu' => '1234567890123456789012',
]);
$response = $this->deleteJson("/api/tenants/acme/bank-accounts/{$account->id}");
$response->assertNoContent();
$this->assertDatabaseMissing('bank_accounts', ['id' => $account->id]);
}
public function test_it_selects_a_bank_account_for_a_tenant(): void
{
$account = BankAccount::query()->create([
'tenant_code' => 'acme',
'titular' => 'John Doe',
'entidad' => 'Banco Galicia',
'alias' => 'john.doe.galicia',
'cvu' => '1234567890123456789012',
]);
$response = $this->postJson("/api/tenants/acme/bank-accounts/{$account->id}/select");
$response->assertOk()
->assertJsonPath('data.selected_bank_account_id', $account->id);
$this->tenant->refresh();
$this->assertEquals($account->id, $this->tenant->selected_bank_account_id);
}
public function test_it_deletes_related_bank_accounts_when_tenant_is_deleted(): void
{
$account = BankAccount::query()->create([
'tenant_code' => 'acme',
'titular' => 'John Doe',
'entidad' => 'Banco Galicia',
'alias' => 'john.doe.galicia',
'cvu' => '1234567890123456789012',
]);
$this->assertDatabaseHas('bank_accounts', ['id' => $account->id]);
$this->tenant->delete();
$this->assertDatabaseMissing('bank_accounts', ['id' => $account->id]);
}
public function test_it_sets_selected_bank_account_id_to_null_when_selected_bank_account_is_deleted(): void
{
$account = BankAccount::query()->create([
'tenant_code' => 'acme',
'titular' => 'John Doe',
'entidad' => 'Banco Galicia',
'alias' => 'john.doe.galicia',
'cvu' => '1234567890123456789012',
]);
$this->tenant->selected_bank_account_id = $account->id;
$this->tenant->save();
$account->delete();
$this->tenant->refresh();
$this->assertNull($this->tenant->selected_bank_account_id);
}
public function test_it_gets_the_selected_bank_account_for_a_tenant(): void
{
$account = BankAccount::query()->create([
'tenant_code' => 'acme',
'titular' => 'John Doe',
'entidad' => 'Banco Galicia',
'alias' => 'john.doe.galicia',
'cvu' => '1234567890123456789012',
]);
// When no bank account is selected
$response = $this->getJson("/api/tenants/acme/bank-accounts/selected");
$response->assertNotFound();
// Select the bank account
$this->tenant->selected_bank_account_id = $account->id;
$this->tenant->save();
// Get selected bank account
$response = $this->getJson("/api/tenants/acme/bank-accounts/selected");
$response->assertOk()
->assertJsonPath('data.id', $account->id)
->assertJsonPath('data.titular', 'John Doe');
}
public function test_it_rejects_unauthenticated_requests(): void
{
$this->app['auth']->forgetGuards();
$response = $this->getJson("/api/tenants/acme/bank-accounts/selected");
$response->assertStatus(401);
$response2 = $this->getJson("/api/tenants/acme/bank-accounts");
$response2->assertStatus(401);
$response3 = $this->postJson("/api/tenants/acme/bank-accounts", []);
$response3->assertStatus(401);
}
}