feat: rename finalize methods to complete for consistency in purchase processing
This commit is contained in:
parent
c276ccd311
commit
f18fbc8147
|
|
@ -120,12 +120,12 @@ class PurchaseController extends Controller
|
|||
], 400);
|
||||
}
|
||||
|
||||
public function finalize(Request $request, Tenant $tenant, Purchase $compra, CheckoutService $checkoutService): PurchaseResource
|
||||
public function complete(Request $request, Tenant $tenant, Purchase $compra, CheckoutService $checkoutService): PurchaseResource
|
||||
{
|
||||
$compra = $this->resolveScopedPurchase($tenant, $request->user()->id, $compra);
|
||||
|
||||
return PurchaseResource::make(
|
||||
$checkoutService->finalizePurchase($compra)
|
||||
$checkoutService->completePurchase($compra)
|
||||
);
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -67,7 +67,7 @@ class CheckoutService
|
|||
});
|
||||
}
|
||||
|
||||
public function finalizePurchase(Purchase $purchase): Purchase
|
||||
public function completePurchase(Purchase $purchase): Purchase
|
||||
{
|
||||
return DB::transaction(function () use ($purchase): Purchase {
|
||||
/** @var Purchase $purchase */
|
||||
|
|
|
|||
|
|
@ -6,5 +6,5 @@ use Illuminate\Support\Facades\Route;
|
|||
Route::prefix('tenants/{tenant:codigo}')->middleware(['auth:sanctum', \App\Domains\Cart\Middleware\MergeGuestCartMiddleware::class])->group(function (): void {
|
||||
Route::apiResource('compras', PurchaseController::class)->only(['index', 'store', 'show']);
|
||||
Route::post('compras/{compra}/payment-intent', [PurchaseController::class, 'paymentIntent']);
|
||||
Route::post('compras/{compra}/finalize', [PurchaseController::class, 'finalize']);
|
||||
Route::post('compras/{compra}/complete', [PurchaseController::class, 'complete']);
|
||||
});
|
||||
|
|
|
|||
|
|
@ -152,7 +152,7 @@ class TelepagosWebhookTest extends TestCase
|
|||
'payment_method' => 'transfer',
|
||||
]);
|
||||
|
||||
$checkoutService->finalizePurchase($purchase);
|
||||
$checkoutService->completePurchase($purchase);
|
||||
|
||||
return $purchase->fresh();
|
||||
}
|
||||
|
|
|
|||
|
|
@ -148,7 +148,7 @@ class StorePurchaseTest extends TestCase
|
|||
]);
|
||||
|
||||
$this->actingAs($user, 'sanctum')
|
||||
->postJson("/api/tenants/sonder/compras/{$purchaseId}/finalize")
|
||||
->postJson("/api/tenants/sonder/compras/{$purchaseId}/complete")
|
||||
->assertOk()
|
||||
->assertJsonPath('data.status', Purchase::STATUS_PENDING_PAYMENT);
|
||||
|
||||
|
|
|
|||
Loading…
Reference in New Issue